feat!: lighten retry logic for LightPush #2182
Conversation
size-limit report 📦
|
|
|
||
| private readonly reliabilityMonitor: SenderReliabilityMonitor; | ||
| export class LightPush implements ILightPush { |
There was a problem hiding this comment.
removed BaseProtocolSDK for now as it is not used
let's follow up in #2186
|
|
||
| export interface ISender { | ||
| send: ( | ||
| encoder: IEncoder, | ||
| message: IMessage, | ||
| sendOptions?: ProtocolUseOptions | ||
| sendOptions?: ISenderOptions |
There was a problem hiding this comment.
this might be a breaking change since ProtocolUseOptions had a variable not in ISenderOptions. If someone has code where that optional variable was set, will it break upon updating?
There was a problem hiding this comment.
true and no, ISenderOptions actually returns previously existed properties and now they are respected in this implementation
so the only breaking change is the naming
There was a problem hiding this comment.
new interface doesn't have forceUseAllPeers?: boolean;
There was a problem hiding this comment.
There was a problem hiding this comment.
good spot, afaik it wasn't used outside some of our tests
weboko
changed the title
Problem
LightPush doesn't use
autoRetryin current version.Solution
Add it and simplify
Notes